Echo a message on setting PKG_CONFIG_PATH #1172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Similar to the message added to third-party/svt.cmd in commit 1a1b4d4.
|
@farindk Dirk: Please review. Would you like me to add the message to other third_party/*.cmd files? |
bradh
reviewed
May 20, 2024
bradh
approved these changes
May 21, 2024
wantehchang
commented
May 21, 2024
| echo "" | ||
| echo "----- NOTE ----" | ||
| echo "Please add the path to the pkg-config file to your PKG_CONFIG_PATH, like this:" | ||
| echo "export PKG_CONFIG_PATH=\$PKG_CONFIG_PATH:$(pwd)/aom/dist/lib/pkgconfig" |
There was a problem hiding this comment.
This path works on all platforms.
| echo "" | ||
| echo "----- NOTE ----" | ||
| echo "Please add the path to the pkg-config file to your PKG_CONFIG_PATH, like this:" | ||
| echo "export PKG_CONFIG_PATH=\$PKG_CONFIG_PATH:$(pwd)/dav1d/dist/lib/x86_64-linux-gnu/pkgconfig" |
There was a problem hiding this comment.
Hi Brad,
I copied this path from the comment at line 4. This path will only work on Linux x86_64. I can clarify that in the message. How about this?
Please add the path to the pkg-config file to your PKG_CONFIG_PATH. For example, on Linux x86_64, run:
export PKG_CONFIG_PATH=$PKG_CONFIG_PATH:$(pwd)/dav1d/dist/lib/x86_64-linux-gnu/pkgconfig
|
@farindk Dirk: Please review. Thanks! |
|
Thank you @wantehchang and @bradh |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to the message added to third-party/svt.cmd in commit 1a1b4d4.